removed langchain, replaced with semantic kernel#8
removed langchain, replaced with semantic kernel#8tarockey wants to merge 5 commits intoAzure-Samples:mainfrom
Conversation
There was a problem hiding this comment.
The Path import appears to have been unnecessary.
| return total_size | ||
|
|
||
|
|
||
| load_image_chain = TransformChain( |
There was a problem hiding this comment.
I could not find any place where this chain was referenced or used, so I removed it. If this was necessary for a larger piece of the solution, let me know so that I can be sure to include a Semantic Kernel replacement.
|
|
||
| service, req_params = get_completion_service() | ||
| # Set the response format to JSON object | ||
| req_params.extension_data["response_format"] = {"type": "json_object"} |
There was a problem hiding this comment.
This assumes using a model that supports structured outputs - if this is not the desired route, this will require refactoring.
|
For reference, MSFT official guidance on OSS AI libraries, LangChain included: https://microsoft-my.sharepoint.com/:w:/p/miscovet/EVBr7JdVZi9Mjyd4JCYvn00BcJYyF6JGIy0OtMtnXDLuOw?e=5GFRWA |
|
Was able to spin up the function app and test successfully both there and in the evaluation notebook. Solution should be stable. |
I just wasn't sure if we wanted to link to an internal MSFT doc in a public repo |
There was a problem hiding this comment.
Is there a reason that we allow only these four locations for the appservice?
There was a problem hiding this comment.
We will need to incorporate the newest changes that are utilizing html instead of markdown
3 participants
Purpose
This change removes LangChain from the repository, replacing it like, for like, with Semantic Kernel, to keep it in line with Microsoft security recommendations from the OSS Security Team.
These changes assume:
I have added comments to the PR where there were assumptions made, or changes may seem ambiguous.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information